Skip to content

Rename AllFlags to AnyFlags #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Conversation

smarter
Copy link
Member

@smarter smarter commented Feb 29, 2016

membersBasedOnFlags(requiredFlags = AnyFlags, excludedFlags = ...) is
easier to understand than
membersBasedOnFlags(requiredFlags = AllFlags, excludedFlags = ...)

Review by @DarkDimius

@smarter
Copy link
Member Author

smarter commented Feb 29, 2016

/rebuild

`membersBasedOnFlags(requiredFlags = AnyFlags, excludedFlags = ...)` is
easier to understand than
`membersBasedOnFlags(requiredFlags = AllFlags, excludedFlags = ...)`
@DarkDimius
Copy link
Contributor

This commit does not seem to actually affect requiredFlags of membersBasedOnFlags.
In the place that it does change, flagMask seem to be actually AllFlags as you mask all flags.

odersky added a commit that referenced this pull request Mar 3, 2016
@odersky odersky merged commit af8fc52 into scala:master Mar 3, 2016
@allanrenucci allanrenucci deleted the rename/AllFlags branch December 14, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants